Make it possible to create virtual clusters with numbers only name #2168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
johannesfrey
force-pushed
the
vcluster-numeric-name
branch
from
68b91b1
to
00ed826
Compare
ThomasK33
reviewed
Sep 24, 2024
johannesfrey
force-pushed
the
vcluster-numeric-name
branch
6 times, most recently
from
614f8be
to
5759162
Compare
johannesfrey
changed the title
johannesfrey
force-pushed
the
vcluster-numeric-name
branch
from
5759162
to
0603105
Compare
ThomasK33
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)resolves ENG-4551
Please provide a short message that should be published in the vcluster release notes
Make it possible to create virtual clusters with digits only name
What else do we need to know?
In order to be able to create virtual clusters with a digits-only name we have to change the way how we create services based on the name. Previously we just used the name verbatim which in case of pure digits violates the DNS-1035 naming convention for service names used by Kubernetes.
It turned out this change cannot only be made to our helm templates as there have been several places in the code base that implicitly rely on services being named like the virtual cluster itself. I hope I found all the places and adjusted them to rely on the service name directly.
The change should be backwards compatible as the
vc-prefix is only prepended to the name when the vcluster name consists of digits only (thx @ThomasK33). So if users already have virtual clusters running with a regular name (e.g. "foo") the service's name will remain "foo" as well.TODO after merge